Repository navigation
ci: allow Node.js download hosts in Sonar workflow - #214
Merged
Merged
Conversation
Include nodejs.org and GitHub release assets in the Sonar workflow allow list to match the Node.js download endpoints used by CI.
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the Node.js download endpoint allow-list update.
No open issues 🎉
What changed in this PR
Updates the SonarCloud workflow’s harden-runner allow list to include hosts used for Node.js downloads.
Changes:
- Adds
nodejs.org:443andrelease-assets.githubusercontent.com:443. - Leaves the existing audit-mode egress policy unchanged.
| File | Description |
|---|---|
.github/workflows/sonarcloud.yml |
Adds two HTTPS endpoints for Node.js downloads to the allow list. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #214 +/- ##
=======================================
Coverage 85.00% 85.00%
=======================================
Files 5 5
Lines 240 240
Branches 53 53
=======================================
Hits 204 204
Misses 1 1
Partials 35 35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Test Results 5 files 5 suites 1m 7s ⏱️ Results for commit bda51b2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
nodejs.org:443andrelease-assets.githubusercontent.com:443to the SonarCloud workflow's harden-runner allow list, matching the endpoints used for Node.js downloads. The existing egress policy remains unchanged. This workflow currently monitors egress in audit mode.Validated the workflow YAML and endpoint list locally.