Repository navigation
ci: remove harden-runner from C++ test workflows - #215
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #215 +/- ##
=======================================
Coverage 85.00% 85.00%
=======================================
Files 5 5
Lines 240 240
Branches 53 53
=======================================
Hits 204 204
Misses 1 1
Partials 35 35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the removal of harden-runner from the C++ test workflows.
No open issues 🎉
What changed in this PR
Removes step-security/harden-runner from the C++ test workflows while leaving build and test steps unchanged.
Changes:
- Removes network egress blocking from all three CTest jobs and sudo restrictions from the matrix-generation and reporting jobs.
- Removes network egress auditing from the vcpkg workflow.
| File | Description |
|---|---|
.github/workflows/ctest.yml |
Removes three harden-runner steps and their network and sudo restrictions. |
.github/workflows/ci-vcpkg.yml |
Removes the harden-runner step configured for network auditing. |
Review effort: Balanced
Test Results 5 files 5 suites 49s ⏱️ Results for commit d31282a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the harden-runner steps from the vcpkg and CTest workflows. This also removes their network egress monitoring and restrictions, including the CTest jobs’ sudo restriction; the build and test steps are unchanged.