Repository navigation
feat(search): add --tool-output to query and tool_output to MCP search_sessions - #81
Open
malihashar wants to merge 1 commit into
Open
malihashar wants to merge 1 commit into
malihashar wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80.
Problem
txcript queryand MCP'ssearch_sessionsnever search tool output — command output, file contents a tool read, API responses. That content is indexed, but the default search scope (Origin::DEFAULT) excludes it, and there's no flag to opt in. A string that only appears inside a tool's output returns "no matches," even thoughtxcript viewshows it plainly.Fix
Adds
--tool-outputtoqueryandtool_output: truetosearch_sessions, both widening toOrigin::ALLthrough the existing shareduser_querypath. The default stays unchanged (tool output is large and noisy — excluding it by default is intentional, perdocs/usage.md). No changes to indexing, ranking, or output format.Tests
New end-to-end tests drive the real CLI and MCP binaries and fail on
main(unknown flag / field), passing after the fix. Library tests cover matches inside one of several tool outputs, mixed-origin sessions, Unicode/case parity with existing search, malformed tool-output shapes, and a ~96-session corpus.