Set a default filename so that Slack displays the file preview correctly - #599
Open
dblock wants to merge 1 commit into
Open
Set a default filename so that Slack displays the file preview correctly#599dblock wants to merge 1 commit into
dblock wants to merge 1 commit into
Conversation
Danger ReportNo issues found. |
dblock
force-pushed
the
fix-files-upload-filename-preview
branch
from
August 29, 2026 22:45
1812651 to
f4e5f47
Compare
Fixes files_upload not showing image previews when filename is not specified, since multipart-post falls back to the local IO path as the filename, which Slack treats as a binary file. Co-authored-by: ts-3156 <ts_3156@yahoo.co.jp> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
fix-files-upload-filename-preview
branch
from
August 29, 2026 22:45
f4e5f47 to
db550e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes #375 as a patch.
Since 2021/05/05, Slack no longer correctly displays image previews for files uploaded via
files_uploadwhen no filename is specified.Faraday::UploadIO/multipart-post falls back to the local IO path as the filename in that case, and Slack treats the file as binary if the filename looks like a path.This sets a default filename of
'file'when:fileis present but:filenameis not, matching the fix originally proposed in #375 by @ts-3156.Closes #375.