Repository navigation
chore: replace requirements.txt with pyproject.toml dependencies - #337
Merged
Merged
Conversation
mwbrooks
marked this pull request as ready for review
October 28, 2026 23:57
zimeg
approved these changes
Oct 29, 2026
| version = "0.0.0" | ||
| requires-python = ">=3.10" | ||
| dependencies = [ | ||
| "slack-cli-hooks==0.3.0", |
Member
There was a problem hiding this comment.
🌲 nit: The other examples spell this slack_cli_hooks with underscores. pip treats both the same, so this is only for consistency, no need to block on it!
Member
Author
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
This pull request makes
pyproject.tomlthe single source of dependencies for each example, so developers install an example and its dev tools with one command:pip install -e ".[dev]".The Slack CLI runs
pip install -e .when it finds apyproject.toml, so this also covers examples created withslack create --subdir.requirements.txtintodependenciesand adevextra formypy,pytest, andruffsrc, so the editable install skipstestspip install -e ".[dev]"in CI and the maintainers guide, and ignores the*.egg-infofolder the editable install writesTesting
ruff check,ruff format --check,mypy ., andpytestall succeed (84, 2, 3, and 3 tests passed,methodshas no tests)Notes
block-kitonlyRequirements