Upgrade bolt-jakarta-jetty to Jetty 12.1 - #1641
Draft
skrcode wants to merge 1 commit into
Draft
Conversation
|
Thanks for the contribution! Before we can merge this, we need @skrcode to sign the Salesforce Inc. Contributor License Agreement. |
skrcode
force-pushed
the
upgrade-bolt-jakarta-jetty-12
branch
from
September 1, 2026 12:28
bc56a8e to
fe3969c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades only
bolt-jakarta-jettyto Jetty 12.1 while leaving the legacybolt-jettymodule unchanged.The adapter stays on Jakarta EE 9, which matches the existing
bolt-jakarta-servletAPI. This change:bolt-jakarta-jettyand excludes that module from the JDK 14 test leg;Serverheader across the default request plus all six Jetty-supportedAcceptforms.Fixes #1567.
Category (place an
xin each of the[ ])Verification
fe3969c5f4efff7f4cf80d6f78bfe18c92f2d038: 7/7 dependency-reactor modules passed; 1,367 tests, 0 failures/errors, 17 skipped; exit code 0. The Maven command took 263 seconds (484 seconds including worker provisioning), and the source object was deleted at termination../mvnw duplicate-finder:check: 22/22 modules passed. The upgraded module has no Servlet API class duplicates; only the repository's existingMETA-INF.versions.9.module-infowarnings remain.AppConfigcalls).bolt-jakarta-jetty, then failed in the unrelatedbolt-quarkus-examplespackaging step. The untouched base SHA reproduces the identical failure.Local Maven invocations used a command-only Central mirror and
-Daws.s3.version=2.42.29because the local Maven cache stalled while enumerating the repository's open AWS SDK version range. No repository dependency property or build tooling was changed for that workaround.AI assistance
JAIPilot assisted with maintainer-intent analysis, migration routing, test design, execution, and diff review. Exact skills used:
jaipilot-maintainer-intent,jaipilot-openrewrite(manual route selected),jaipilot-generate-tests,jaipilot-fast-execution,jaipilot-review-diff, andjaipilot-remote-java. See JAIPilot.gpt-5.6-solxhighfastThe remote build received only an archive of the exact committed SHA. Its source object was deleted and its worker terminated after the build.
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.