[kyungyeon-byun-imweb-me]

Summary

Fixes #2753.

SocketModeClient currently assumes every events_api payload contains payload.event.type. Slack's documented app_rate_limited payload has its event type at the top level and no inner event, so that assumption throws before consumers can acknowledge the envelope.

This change:

• dispatches a valid inner event when present, preserving existing behavior;
• otherwise dispatches a valid top-level payload type, including app_rate_limited;
• skips only the specific event emission for malformed payloads while preserving the generic slack_event emission and ACK function;
• adds focused regression coverage for normal callbacks, app_rate_limited, malformed payloads, and invalid inner-event type fallback;
• includes a patch changeset for @slack/socket-mode.

Validation completed:

• npm run build --workspace=@slack/logger
• npm run build --workspace=@slack/types
• npm run build --workspace=@slack/web-api
• npm run build --workspace=@slack/socket-mode
• npm test --workspace=@slack/socket-mode (43 passing)
• npm run lint

Requirements

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[changeset-bot]

🦋 Changeset detected

Latest commit: f91f6a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@slack/socket-mode	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[salesforce-cla]

Thanks for the contribution! Before we can merge this, we need @kyungyeon-byun-imweb-me to sign the Salesforce Inc. Contributor License Agreement.

[kyungyeon-byun-imweb-me]

@salesforce-cla The license agreement has been signed. Thank you.

[mwbrooks]

✅ Thanks @kyungyeon-byun-imweb-me! 🎉 Congrats on your first contribution to the Node Slack SDK, and thanks for the thorough tests too!

[mwbrooks]

suggestion (non-blocking): Could we debug-log when we skip the specific emit? It'll help someone wondering why their listener never fired.

Suggested change

	});
	} else {
	this.logger.debug(`Received an events_api message without an event type (envelope_id: ${event.envelope_id})`);
	}

[mwbrooks]

Addressed in df7676a

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.32%. Comparing base (bf3ca27) to head (f91f6a4).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2754      +/-   ##
==========================================
+ Coverage   89.28%   89.32%   +0.04%     
==========================================
  Files          65       65              
  Lines       10555    10562       +7     
  Branches      481      489       +8     
==========================================
+ Hits         9424     9435      +11     
+ Misses       1099     1095       -4     
  Partials       32       32              

Flag	Coverage Δ
cli-hooks	89.21% <100.00%> (-0.02%)	⬇️
cli-test	89.21% <100.00%> (-0.02%)	⬇️
logger	89.21% <100.00%> (-0.02%)	⬇️
oauth	89.21% <100.00%> (-0.02%)	⬇️
socket-mode	89.21% <100.00%> (-0.02%)	⬇️
web-api	89.21% <100.00%> (-0.02%)	⬇️
webhook	89.21% <100.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.