[mwbrooks]

Changelog

slack install and slack run now stop before creating an app on an Enterprise organization when the app manifest doesn't set "org_deploy_enabled": true, and explain how to fix it. Before, the app installed but never received events.

Summary

This pull request stops developers on an Enterprise organization from installing an app that will never receive events. With an org login, the CLI creates the app on the organization. An app that is not org ready installs and shows as Installed, but Slack delivers no events to it. Fixes #723.

• New apps and uninstalled org apps are checked before apps.manifest.create and apps.developerInstall. Apps that are already installed are not affected.
• A missing org_deploy_enabled counts as not org ready, because it defaults to false.
• The error suggests adding "org_deploy_enabled": true, or creating the app on a workspace and linking it with slack app link.

Testing

• With an org login and a manifest that has "org_deploy_enabled": false or leaves it out, slack install errors with app_not_org_ready and no app is created.
• With "org_deploy_enabled": true, slack install and slack run create the app on the organization and prompt for the workspace grant as before.
• With a workspace login, the same manifests install as before.

Notes

• This is a hard error, not a warning with a confirm prompt. A softer warning would still let the app install at the org level, where it gets no events.
• docs/reference/errors.md picks up the new error code on the next release.

Requirements

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[codecov]

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.17%. Comparing base (02e6287) to head (8999e77).

Files with missing lines	Patch %	Lines
internal/pkg/apps/install.go	84.61%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
+ Coverage   78.16%   78.17%   +0.01%     
==========================================
  Files         240      240              
  Lines       18153    18166      +13     
==========================================
+ Hits        14190    14202      +12     
- Misses       3963     3964       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[zimeg]

🏢 @mwbrooks LGTM! Thanks for catching apps that install on an org but never hear an event. Stopping before apps.manifest.create is the right place for this, and the tests cover the new, uninstalled, and installed cases nicely ✨

[zimeg]

👁️‍🗨️ praise: Both paths forward in the remediation is so helpful! The slack app link fallback is a nice option for anyone who can't change the manifest.

[zimeg]

🔁 question: Should this also cover reinstalling an org app that's still installed? If org_deploy_enabled is removed from the manifest later, slack install or slack run on an installed org app skips this check, since it's neither new nor uninstalled. I'm not sure whether that app keeps receiving events or goes quiet like the new case, so a follow-up might not be needed!