Repository navigation
feat: track template shortcut and subdirectory used with create - #737
Draft
lukegalbraithrussell wants to merge 1 commit into
Draft
lukegalbraithrussell wants to merge 1 commit into
lukegalbraithrussell wants to merge 1 commit into
Conversation
Adds template_shortcut and template_subdir to the app event data sent with telemetry so usage of "slack create agent" and the selected agent framework can be measured. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
=======================================
Coverage 78.18% 78.19%
=======================================
Files 240 240
Lines 18166 18176 +10
=======================================
+ Hits 14203 14212 +9
- Misses 3963 3964 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
N/A — telemetry only, no change to the user experience.
Summary
This pull request adds the template shortcut and template subdirectory to the telemetry event sent by
slack create.We want to measure how app templates are chosen, and today's telemetry can't answer these questions:
agentshortcut used?slack create agentandslack createwith "AI apps" picked from the menu send the same event (command: "create", samedata.app.template), because positional arguments aren't recorded.data.app.templateonly holdsowner/repo, so the Claude Agent SDK and OpenAI Agents SDK variants of a starter (subdirectories of the same repo) can't be told apart.Changes:
data.app.template_shortcut(e.g.agent, empty otherwise) anddata.app.template_subdir(e.g.claude-agent-sdk, from--subdiror the selected template) toAppEventData, bothomitempty.template_subdirthe same way astemplate, since custom--subdirvalues are user input.slack samplesrunscreateinternally, so it records these fields too.slack initdoesn't use templates and is unchanged.data.app.templatekeep working.Example event data for
slack create agent my-app→ Starter Agent → Bolt for JavaScript → Claude Agent SDK:Preview
N/A
Testing
make build../bin/slack create agent my-agent --verbose, select a starter, a framework, and an agent SDK.FlushToLogstash will POSTdebug line, confirmdata.app.template_shortcutisagentanddata.app.template_subdirmatches the chosen SDK../bin/slack create my-app -t slack-samples/bolt-js-starter-template --verboseand confirm neither new field is present.Notes
Requirements
Co-Authored-By: Claude svc-devxp-claude@slack-corp.com