Promote to production: full-screen reading for viewer tools - #382
Merged
Conversation
Add a shared ExpandableViewer wrapper (built on the useExpand hook: native Fullscreen API + iOS CSS-overlay fallback, Esc to exit) and wrap 13 viewer tools with it so each can be read full-screen — handy on a phone: PPTX, Legacy .doc, GEDCOM, EML, DICOM, iWork, DOCX, Spreadsheet/ CSV, EPUB, ODT, Image, SVG and GeoJSON/GPX/KML viewers. Happy-path E2E asserts the toggle on two representative viewers; the registry render smoke covers all 13.
feat(viewers): full-screen reading for document, image & map viewers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes PR #381: shared ExpandableViewer (useExpand) adds a Full screen toggle to 13 viewer tools (PPTX, .doc, GEDCOM, EML, DICOM, iWork, DOCX, Spreadsheet/CSV, EPUB, ODT, Image, SVG, Geo). CI green on develop.