test(fruit-merge): de-flake score assertion by varying drop positions - #385
Merged
Conversation
The happy-path test dropped every fruit at the exact center column, which is pathological — fruits stack without reliable same-tier lateral contact, so occasionally nothing merges and the score stays 0 (intermittent CI failures). Spread the drops across x positions (as the restart test already does) so a same-tier contact is near certain, stop early on board-full, and give the post-drop merge a little longer to resolve.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| 🔵 In progress View logs |
goodwebtools | 8dac97b | Sep 11 2026, 10:42 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fruit Merge happy-path E2E dropped every fruit at the exact center column — pathological (fruits stack without reliable same-tier lateral contact), so occasionally nothing merges and the score stays
0. This caused intermittentPlaywright · Ask Agentfailures that blocked several unrelated PRs this session (3 spurious reds).Fix: spread the drops across x positions (like the restart test already does), stop early on board-full, and give a post-drop merge a bit longer to resolve. Verified locally with
--repeat-each 3(3/3 pass, and faster — merges land early).