Add stellar block metadata to latestLedger#687
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
product-security-plaid-production
Bot
requested review from
Unheilbar,
jmank88 and
nolag
July 15, 2026 14:52
jmank88
approved these changes
Jul 15, 2026
ilija42
enabled auto-merge
July 15, 2026 14:56
|
dhaidashenko
approved these changes
Jul 15, 2026
| LedgerCloseTime: ledger.LedgerCloseTime, | ||
| } | ||
|
|
||
| hash, err := hex.DecodeString(ledger.Hash) |
Contributor
There was a problem hiding this comment.
Nit: in all other caps, we have conversion from service reply to capability reply in common
Contributor
Author
There was a problem hiding this comment.
I have to pull in the stellar xdr library to make the decoding easier, I can't do that in chainlink-common
Contributor
Author
There was a problem hiding this comment.
so I could do a hybrid or just have everything in one place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.