Lint Roller 14: system-tests

[kalverra]

Issues Fixed

Linter	Issues Fixed
testifylint	58
revive	27
prealloc	14
gocritic	7
staticcheck	3
Total	109

Packages Covered

• system-tests/lib
• system-tests/tests/...

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[github-actions]

CORA - Pending Reviewers

Codeowners Entry	Overall	Num Files	Owners
*	⏳	87	@smartcontractkit/foundations, @smartcontractkit/core
/core/services/pipeline/	⏳	1	@smartcontractkit/foundations, @smartcontractkit/bix-framework, @smartcontractkit/core
/tools/test/	⏳	1	@smartcontractkit/devex-cicd, @smartcontractkit/devex-tooling, @smartcontractkit/core

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

[github-actions]

✅ No conflicts with other open PRs targeting develop

[github-actions]

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[trunk-io]

   

Failed Test	Failure Summary	Logs
TestConnectionManager_ReadyForTrafficRequiresEveryShard	The test failed because the connection manager reported that a shard was not ready for traffic due to insufficient connected nodes, and an unexpect...	Logs ↗︎

View Full Report ↗︎ ⋅ Docs

[cl-sonarqube-production]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube