feat(ci): dynamic spot instance usage - #23555
Open
kalverra wants to merge 4 commits into
Open
Conversation
product-security-plaid-production
Bot
requested review from
justinkaseman,
pavel-raykov,
skudasov and
tvc-robsondebraga
August 26, 2026 21:21
Contributor
|
👋 kalverra, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
✅ No conflicts with other open PRs targeting |
|
|
kalverra
force-pushed
the
DX-5101/spot-instances
branch
from
August 27, 2026 17:59
9a180b6 to
0dbce29
Compare
kalverra
force-pushed
the
DX-5101/spot-instances
branch
from
August 27, 2026 18:22
0dbce29 to
73c5449
Compare
erikburt
previously approved these changes
Aug 28, 2026
Comment on lines
80
to
83
| - name: Define test matrix | ||
| id: define-matrix | ||
| shell: bash | ||
| run: | |
Collaborator
There was a problem hiding this comment.
Ideally ${{ steps.spot.outputs.spot_flag }} is injected as an env var instead of templated.
kalverra
force-pushed
the
DX-5101/spot-instances
branch
from
August 31, 2026 15:22
73c5449 to
6d3acb1
Compare
|
kalverra
force-pushed
the
DX-5101/spot-instances
branch
from
August 31, 2026 18:17
6d3acb1 to
afecaa2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Determine what spot strategy we should use based on the branch name + CI event. Avoid using spot instances where failures evicitons are the most annoying (merge queue, release branches)
Stack created with GitHub Stacks CLI • Give Feedback 💬