Repository navigation
Check version consistency from the source tree - #926
Merged
Merged
Conversation
kuhe
marked this pull request as ready for review
November 11, 2026 21:29
lukasdchang
approved these changes
Nov 11, 2026
Comment on lines
+124
to
+125
| and (value.func.id if isinstance(value.func, ast.Name) else value.func.attr) | ||
| == "version" |
There was a problem hiding this comment.
Should this check if version is under importlib.metadata.version. It currently accepts any function or method named version including ones imported from an unrelated module.
Contributor
Author
There was a problem hiding this comment.
merging without this change since it is a remote edge case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the version consistency check to read versions from source code files under version control rather than what's available in the local env, which lags behind without constant updates.