Repository navigation
Support endpoint trait host prefixes - #933
Merged
Merged
Conversation
arandito
marked this pull request as ready for review
November 12, 2026 15:00
kuhe
reviewed
Nov 12, 2026
| from smithy_http.aio.aiohttp import AIOHTTPClient | ||
|
|
||
| from .._private.endpoints import BDD | ||
| from .._private.schemas import AWS_EC2 |
Contributor
There was a problem hiding this comment.
AWS_EC2 is not defined or imported in ec2query._private.schemas
what's this warning about? isn't this the service schema, which should exist?
Contributor
Author
There was a problem hiding this comment.
Looks like a false positive that's already on develop. AWS_EC2 lives in a lazily loaded schema partition, which the static canonical-imports check doesn't check.
kuhe
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the
@endpointtrait'shostPrefixand@hostLabelmembers across all protocols.Added
endpoint_uri.HOST_PREFIXcontext property insmithy_core.endpoints, holding the expanded prefix.EndpointResolutionErrorbefore the request is sent.disable_host_prefix_injectionconfig field, generated only for services with@endpointoperations.{AccountId}.host prefix, since its endpoint rules already place the account ID.Removed (breaking, smithy-http)
HostPrefixSerializerandBinding.HOST.@hostLabelno longer changes where a member is serialized.HTTPOperationSchemaMetadata.host_prefixand theendpoint_traitparameters on the HTTP serializers.set_service_endpointoverwrote the host they built. The pipeline now handles host prefixes for every protocol. Additionally, the Smithy spec states thathostLabelmust not affect a member's serialization.Testing
WriteGetObjectResponseand S3 Control{AccountId}.endpoint cases.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.