fix: clean up ack callback on emitWithAck timeout#5521
Open
mayank-dev-15 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
emitWithAckon the server side, memory is not freed when the acknowledgement timeout is reached. With 500 client connections and periodic broadcast emissions, memory usage grows to 1557MB after 3 hours.Root Cause
In
BroadcastOperator.emit(), when the timeout fires, theresponsesarray (which accumulates client acknowledgements) is passed to the error callback but never released. The closure retains a reference to the growingresponsesarray even after timeout, preventing GC from reclaiming the memory.Fix
Clear the
responsesarray immediately after passing it to the error callback in the timeout handler. This releases the accumulated responses and allows the closure to be garbage collected.ack.apply(this, [ new Error("operation has timed out"), this.flags.expectSingleResponse ? null : responses, ]); + responses = []; }, this.flags.timeout);Testing
socket.acksFixes #4984