fix(eio): report oversized polling payloads - #5550
Open
wangxpych wants to merge 1 commit into
Open
Conversation
Emit the existing transport error after a polling request exceeds maxHttpBufferSize so server-side disconnect handlers receive an actionable description. Assisted-by: OpenAI Codex:gpt-5 Signed-off-by: xuping.wang <2232455931@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxHttpBufferSizeTransportErrorContext
The polling transport returned HTTP 413 when the incoming body crossed the configured limit, but it did not notify the Engine.IO socket about the cause. As a result, server-side Socket.IO handlers only received
transport closewithout a description.The uWebSockets polling implementation already reports
payload too large, and the WebSocket implementation reports the correspondingwsrange error. This change brings the Node.js polling transport in line with those paths by using the existing transport error pipeline after the request has been cleaned up.Fixes socketio/engine.io#706
Verification
npm run compile --workspace=engine.ionpm run format:check --workspace=engine.iotransport closeand passes after the fix withtransport error/payload too largeThe aggregate
npm test --workspace=engine.iocommand reaches 175 passing tests but the local WebTransport test times out because the optional@fails-components/webtransport-transport-http3-quichenative module is not built in this environment.AI assistance disclosure: OpenAI Codex assisted with reproduction, implementation, and verification. The change was reviewed and tested against the repository's current main branch.