fix: add explicit thrust/tuple.h for CUDA 13 compatibility - #1114
Closed
KimYannn wants to merge 1 commit into
Closed
fix: add explicit thrust/tuple.h for CUDA 13 compatibility#1114KimYannn wants to merge 1 commit into
KimYannn wants to merge 1 commit into
Conversation
CUDA 13 (CCCL refactor) no longer implicitly pulls thrust::get into scope via thrust/sort.h or thrust/merge.h. Add the explicit include so thrust::get compiles on CUDA 13+ while remaining backward compatible with all older CUDA versions. Fixes build error: namespace "thrust" has no member "get" Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
Thanks! This was fixed as part of some other refacting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#include <thrust/tuple.h>tolib/libmarv/src/cudasw4.cuhCUDA 13 (CCCL refactor) reorganized Thrust's internal header dependencies. As a result,
thrust::getis no longer implicitly available via<thrust/sort.h>or<thrust/merge.h>, causing a build failure:The fix adds an explicit
#include <thrust/tuple.h>which is backward compatible with all CUDA versions ≥ 7.Test plan
<thrust/tuple.h>has existed since Thrust 1.x — no regression on older CUDA versions🤖 Generated with Claude Code