Repository navigation
[Web] Make ScrollView an intercepting detectors - #4528
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly identifies the main change: making the web ScrollView use intercepting gesture detectors. The grammar is imperfect, but the meaning is clear. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
🟢 Approval recommended
The change matches native behavior and has no unresolved review comments.
Pull request overview
Updates the web ScrollView to use intercepting gesture-detector behavior, matching native platforms.
Changes:
- Applies
GestureDetectorType.Interceptingto the webScrollView.
File summaries
| File | Description |
|---|---|
packages/react-native-gesture-handler/src/v3/components/GestureComponents.web.tsx |
Makes the web ScrollView an intercepting detector. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Description
On Android and iOS the
ScrollViewwrappers are created withGestureDetectorType.Intercepting, so aVirtualGestureDetectorrendered inside them has an intercepting ancestor. The web wrappers were created with the default detector type, so the same code throwsThis PR passes
GestureDetectorType.Interceptingto the webScrollViewTest plan
Checked ScrollView example