Repository navigation
fix(ui): prevent hovered sibling from overlapping focused IconButton ring - #22
Merged
Merged
Conversation
lxsmnsyc
self-requested a review
October 20, 2026 13:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when hovering a button right after a focused button in the DOM, the hovered button's background would paint over the focused button's outline ring and cut off one side of it.
This adds
position: relative; z-index: 1;to[data-solid-icon-button]:focusso the focus ring stays above adjacent hovered buttons.Before
After
P.S. Very happy to make my first contribution to Solid! Even though it's devtools and not core, it's the first of a few visual/UX fixes I'm planning to send over.