Repository navigation
fix(reactivity-ui): fix graph connection arrow and line alignment, fix arrow not inhereting connection dynamic color - #23
Merged
Conversation
…ctive" behaviour with `markerUnits="userSpaceOnUse"` attribute
Contributor
Author
|
Grew a bit out of scope from just fixing the misalignment (as you can see from the branch name), but while I was in here I couldn't resist fixing the arrow coloring bug too |
lxsmnsyc
approved these changes
Oct 20, 2026
lxsmnsyc
left a comment
Member
There was a problem hiding this comment.
I always forget to fix this so this change is welcome. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to.x). Because the curve was still bending over the arrowhead's length, the incoming line visually drifted and entered the back of the horizontal arrow off-center. Edges now stopARROW_SIZE(8px) before the node, connecting straight into the base of the arrowhead.<marker>path fill fromcurrentColortocontext-strokeso arrowheads actually inherit the edge's dynamic stroke color (signals/effects/selection) instead of falling back to the SVG container's text color.#solid-reactivity-arrow-activemarker with an adjustedrefXoffset so highlighted arrows scale up nicely while remaining pinned to the node boundary.layout.test.tsto account forARROW_SIZEinedgePath.Before
After