Repository navigation
fix: annotate non-JSX modules with lazy module URLs - #407
Merged
Merged
Conversation
Plain .ts/.js files returned before the lazy pipeline, so a routes.ts callsite never got a module URL and an SSR target never got $$moduleUrl. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: af79dd8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transform(), after the existing primitive-names pass, also runtransformLazyAsync,resolveLazyModuleUrls, andinjectSsrModuleId. Aroutes.tsoflazy(() => import(...))now gets a project-relative callsite module URL, and an SSR.ts/.jsmodule getsexport const $$moduleUrl.sourceNames/namePrimitives/observe..ts/.js(including.mjs/.cjs/.mts/.cts) stay off the JSX parser and off solid-refresh."use server"stays inserverFunctions()..d.tsis skipped.$$moduleUrlstill is not stamped insidenode_modules(injectSsrModuleId). Lazy still runs for a non-JSX script innode_moduleswhen the source containslazy, matching the JSX path.Fixes #406
Test plan
pnpm exec tsc --noEmitandpnpm buildexamples/ssrsuite, includingtest/ts-module-url.mjs: withsolid.sourceNames: false, a.tscallsite gets the project-relative module URL in dev and in a production build, an SSR.tstarget gets$$moduleUrl, the client build does not, and a.d.tsis not stampedexamples/start-ssrproduction build still succeedsMade with Cursor