fix(solid): avoid hydrating refresh registration - #2921
Conversation
🦋 Changeset detectedLatest commit: 39ceacb The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merging this PR will improve performance by ×2.2
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | merge |
165.1 µs | 73.4 µs | ×2.2 |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing brenelz:fix/refresh-lazy-hydration (39ceacb) with next (ec432b4)
|
Thanks @brenelz! A fix for #2920 was already in flight locally, but your plain-signal approach is cleaner — no writable memo, nothing hydration-aware to work around — so I adopted it. It just landed on |
Summary
Tests
pnpm testinpackages/solid(488 passed)pnpm test-typesinpackages/solidgit diff --checkFixes #2920