Skip to content

fix(signals): align store overloads - #3260

Open
GabbeV wants to merge 3 commits into
solidjs:nextfrom
GabbeV:fix/align-store-overloads
Open

fix(signals): align store overloads#3260
GabbeV wants to merge 3 commits into
solidjs:nextfrom
GabbeV:fix/align-store-overloads

Conversation

@GabbeV

@GabbeV GabbeV commented Sep 3, 2026

Copy link
Copy Markdown

Summary

Align store overloads across @solidjs/signals and the solid-js client/server entry points.

  • Standardize plain forms as (initialValue, options?) and derived forms as (fn, seed, options?).
  • Move shallow to StoreOptions; keep projection-only fields on ProjectionOptions.
  • Expose the existing options argument on plain optimistic stores.
  • Type derived optimistic stores as Refreshable<Store<T>>.
  • Align async-iterable support and option types across entry points.
  • Add focused type coverage and a changeset.

Depends on #3258 and should be rebased onto next after it merges.

Validation

  • pnpm types (packages/signals)
  • pnpm test-types and pnpm types (packages/solid)
  • Shallow-store and optimistic-store focused tests

@changeset-bot

changeset-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f45a213

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@solidjs/signals Patch
solid-js Patch
test-integration Patch
@solidjs/web Patch
@solidjs/element Patch
@solidjs/h Patch
@solidjs/html Patch
@solidjs/universal Patch
@solidjs/babel-plugin Patch
@solidjs/compiler Patch
@solidjs/diagnostics Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codspeed-hq

codspeed-hq Bot commented Sep 3, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 32.71%

❌ 1 regressed benchmark
✅ 135 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
merge 187.9 µs 279.2 µs -32.71%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing GabbeV:fix/align-store-overloads (f45a213) with next (ff96a67)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant