[GabbeV]

Summary

A throwing reactive onCleanup during an unfinished memo's rerun leaves the module-global deferredReleases collector installed. After the caller catches the error, disposing an unrelated lazy memo's last observer appends it to the abandoned collector instead of releasing it, so its cleanup does not run.

This regresses behavior before #4164: the public-signals repro runs the unrelated cleanup once on its direct parent, a9b9f9e4, but zero times on the tested base, a2743fa2. The cleanup error escapes in both versions.

Restore the previous collector in finally. This restores the earlier release behavior while preserving the original exception, interrupted teardown, and successful-pass deferral/draining behavior. Adds throwing/non-throwing public-API regressions and a patch changeset.

Minimal JSX playground: click Run to see Cleanup count: 0; replacing the throw with return and rebuilding gives 1. The hosted package build is mizulu/solid2@5a4b2e85; the same component separately reproduces against unchanged upstream source at a2743fa2.

How did you test this change?

• The new throwing case fails before the fix (cleaned is 0 instead of 1); the non-throwing control passes. Both pass after the fix and check that the original cleanup error still escapes. Existing rebuilt-reader/lazy-release regressions also pass.
• Signals JS build and source declaration check pass.
• Full signals suite: 327 files, 5,411 tests passed, three expected failures and two skips. The unchanged base passes 326 files / 5,409 tests.
• Prettier checks on all three files and node scripts/check-release-invariants.mjs pass.
• Rolldown 1.2.11: +13 minified bytes in each of the four signals scenarios. All comparison gates pass; createStore has a brotli warning within the existing minified allowance. No caps changed.
• Focused local production timings on Node 24.19.0: five warm-up batches per version and 11 alternating measured rounds for chains, diamonds and pending-frame rebuilds. Patched medians were within 3% of the base, with no apparent slowdown; these noisy microbenchmarks are not an application-performance guarantee.

[changeset-bot]

🦋 Changeset detected

Latest commit: 035e9b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages

Name	Type
@solidjs/signals	Patch
test-integration	Patch
@solidjs/web	Patch
@solidjs/babel-plugin	Patch
@solidjs/compiler	Patch
@solidjs/diagnostics	Patch
@solidjs/element	Patch
@solidjs/h	Patch
@solidjs/html	Patch
solid-js	Patch
@solidjs/universal	Patch
board-example	Patch
server-dbmon-example	Patch
todos-server-example	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codspeed]

Merging this PR will regress 1 benchmark

⚠️ 4 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

• build + consume
• propagation:diamond
• readAllowed
• middle: remove at 500 + insert at 500 (1000 rows)

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 194 untouched benchmarks
⏩ 5 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	BASE	HEAD	Efficiency
❌ ⚠️	build + consume	693.9 µs	776.7 µs	-10.67%
⚡	memo + sync render effect only (reference)	33.6 ms	28.7 ms	+17.19%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing GabbeV:fix/restore-deferred-releases (035e9b2) with next (b0ad1df)}

Footnotes

1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩