chore(size): raise caps for #4310 and #4325 by ryansolid · Pull Request #4327 · solidjs/solid

ryansolid · 2026-10-27T16:11:36Z

Summary

Before: #4310 (store fold keeps its $OWNER stamp) and #4325 (delegated dispatch restores currentTarget/target) each fail the size gate. next has used up the 20 B minified allowance on four scenarios.

After: those four caps and their recorded minified sizes cover next + #4310 + #4325, so both fixes pass the gate once they pick up this change.

How: I measured locally (linux) on next at 2c9fdd9 (with #4319) merged with #4310 and #4325. Each cap is the measured brotli + 10 B, rounded up to 0.01 KB, and each recorded minified size is the measured value. Each scenario gets a dated ledger line above its limit:. Today's local numbers have matched CI's exactly.

scenario	cap	recorded minified
app: hydrating + every store primitive family	30.96 → 30.98 KB	95,147 → 95,185 (+38)
page: live server components (frozen floor)	37.75 → 37.91 KB	115,217 → 115,260 (+43)
page: compiled live server components	41.56 → 41.78 KB	123,216 → 123,253 (+37)
page: live + router	47.16 → 47.38 KB	140,480 → 140,514 (+34)

The brotli steps are bigger than the minified ones because next was already over these brotli caps within its allowance. #4325 adds +23 B minified to every web client scenario, and #4310 adds +15 B to the store scenario. The rest is #4319's growth, which fit its allowance. Hello world (app: compiled floor) measures 9,972 B brotli with both fixes, under 10 KB.

If #4326 (the smaller #4312 rewrite, −95 B minified everywhere) lands first, these raises aren't needed and can be dropped.

Size-Exception: page: live server components +43 B minified (37.91 KB) from #4325's delegated currentTarget/target restore (+23 B) and #4319's fresh-render claim fix, plus app: hydrating + every store primitive family +38 B from #4310 and #4325. Bug fixes; hello world stays under 10 KB. Accepted by the maintainer (2026-10-27).

How did you test this change?

With these caps, node gate.mjs on next + fix(signals): store fold keeps the $OWNER stamp on a privatized backing #4310 + fix(web): delegated dispatch restores currentTarget and target (no try) #4325 passes: warnings only, no failures.
prettier --check is clean on both files.

Generated by Claude Code

Re-records the four scenarios the store fold stamp (#4310) and the delegated currentTarget/target restore (#4325) push past their minified allowance, measured over next with #4319. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018LY7F9czoRqdMEvk2QwPr1

changeset-bot · 2026-10-27T16:11:44Z

⚠️ No Changeset found

Latest commit: 6e4b7d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-10-27T16:14:46Z

Size (brotli, eager entry chunk)

scenario	head	minified vs recorded	cap		lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush)	7.42 KB	−119 B	7.44 KB	✅
signals: + createStore	14.87 KB	−1463 B	15.04 KB	✅
signals: + isPending/latest	10.38 KB	−8 B	10.38 KB	✅
signals: + until/refresh (truth readers, no optimism)	8.05 KB	−123 B	8.05 KB	✅
app: render + one signal (the simple-app floor)	9.78 KB	−107 B	9.75 KB	⚠️ over by 29 B, 127 B minified headroom
app: hydrating (no stores) with Show/For/Loading/Errored/lazy	18.61 KB	−180 B	18.49 KB	⚠️ over by 122 B, 200 B minified headroom	lazy-page.js 0.04 KB
app: hydrating + every store primitive family	30.94 KB	−38 B	30.98 KB	✅	lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy	13.39 KB	−186 B	13.40 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the `observe` artifacts)	15.10 KB	−189 B	15.14 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled	29.69 KB	−190 B	29.70 KB	✅	lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click)	9.96 KB	−106 B	9.93 KB	⚠️ over by 26 B, 126 B minified headroom
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store)	26.14 KB	−736 B	26.27 KB	✅	stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable)	32.24 KB	−663 B	32.25 KB	✅	stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec)	11.75 KB	0 B	11.76 KB	✅
page: base server components (hydrating + dynamic + frames + sf reference)	33.45 KB	−177 B	33.37 KB	⚠️ over by 78 B, 197 B minified headroom	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 8.92 KB, wire.js 3.47 KB
page: live server components (base + live/GET + action + isPending/latest)	37.92 KB	−23 B	37.91 KB	⚠️ over by 11 B, 43 B minified headroom	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 8.93 KB, wire.js 3.47 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread)	35.53 KB	−160 B	35.43 KB	⚠️ over by 97 B, 180 B minified headroom	assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 8.94 KB, wire.js 3.47 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest)	41.77 KB	−23 B	41.78 KB	✅	eager (counted): web.js 22.32 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.19 KB, trace.js 8.94 KB, wire.js 3.47 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate)	40.95 KB	−179 B	40.81 KB	⚠️ over by 139 B, 199 B minified headroom	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, server.js 1.03 KB, serverForms.js 3.58 KB, trace.js 8.97 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate)	47.32 KB	−23 B	47.38 KB	✅	eager (counted): client.js 27.42 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.32 KB, trace.js 8.95 KB, wire.js 3.49 KB
server: floor (getRequestEvent + isServer)	1.27 KB	−69 B	1.34 KB	✅
server: renderToString (the server-render floor)	22.79 KB	0 B	22.80 KB	✅

⚠️ Over the brotli cap within the minified allowance (passes)

app: render + one signal (the simple-app floor): over brotli cap by 29 B; minified 26,922 B vs 27,029 B recorded with the cap (−107 B) — 127 B of the 20 B minified allowance left; +0 B minified over this PR's base
app: hydrating (no stores) with Show/For/Loading/Errored/lazy: over brotli cap by 122 B; minified 53,440 B vs 53,620 B recorded with the cap (−180 B) — 200 B of the 20 B minified allowance left; +0 B minified over this PR's base
app: compiled floor (one template, one text hole, one delegated click): over brotli cap by 26 B; minified 27,454 B vs 27,560 B recorded with the cap (−106 B) — 126 B of the 20 B minified allowance left; +0 B minified over this PR's base
page: base server components (hydrating + dynamic + frames + sf reference): over brotli cap by 78 B; minified 101,382 B vs 101,559 B recorded with the cap (−177 B) — 197 B of the 20 B minified allowance left; +0 B minified over this PR's base
page: live server components (base + live/GET + action + isPending/latest): over brotli cap by 11 B; minified 115,237 B vs 115,260 B recorded with the cap (−23 B) — 43 B of the 20 B minified allowance left; +0 B minified over this PR's base
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread): over brotli cap by 97 B; minified 107,758 B vs 107,918 B recorded with the cap (−160 B) — 180 B of the 20 B minified allowance left; +0 B minified over this PR's base
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate): over brotli cap by 139 B; minified 125,208 B vs 125,387 B recorded with the cap (−179 B) — 199 B of the 20 B minified allowance left; +0 B minified over this PR's base

_{Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).}

coveralls · 2026-10-27T16:22:28Z

Coverage Report for CI Build 40538487247

Coverage remained the same at 78.727%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	1357
Covered Lines:	1127
Line Coverage:	83.05%
Relevant Branches:	1078
Covered Branches:	790
Branch Coverage:	73.28%
Branches in Coverage %:	Yes
Coverage Strength:	28.41 hits per line

💛 - Coveralls

codspeed · 2026-10-27T16:35:30Z

Merging this PR will improve performance by 11.25%

2 warnings

⚠️ 4 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
✅ 194 untouched benchmarks
⏩ 5 skipped benchmarks¹

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`createStore setter: delete + set one root key (#3044 overlay)`	2.1 ms	1.8 ms	+17.1%
⚡	`build`	139.6 µs	132.1 µs	+5.7%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing size/caps-4310-4325 (6e4b7d4) with next (0c6db49)²}

5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on next (2c9fdd9) during the generation of this report, so 0c6db49 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

ryansolid · 2026-10-27T16:49:49Z

Not needed: #4326 landed first and its −95 B leaves room for #4310 and #4325 under the existing caps (checked locally: gate passes with warnings only, hello world 9,968 B).

Generated by Claude Code

ryansolid closed this Oct 27, 2026

Navigation Menu

Repository navigation

chore(size): raise caps for #4310 and #4325 - #4327

chore(size): raise caps for #4310 and #4325#4327
ryansolid wants to merge 1 commit into
nextfrom
size/caps-4310-4325

ryansolid commented Oct 27, 2026

Uh oh!

changeset-bot Bot commented Oct 27, 2026

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

coveralls commented Oct 27, 2026

Uh oh!

codspeed Bot commented Oct 27, 2026

Uh oh!

ryansolid commented Oct 27, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ryansolid commented Oct 27, 2026

Summary

How did you test this change?

Uh oh!

changeset-bot Bot commented Oct 27, 2026

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Oct 27, 2026

Size (brotli, eager entry chunk)

⚠️ Over the brotli cap within the minified allowance (passes)

Uh oh!

coveralls commented Oct 27, 2026

Coverage Report for CI Build 40538487247

Coverage remained the same at 78.727%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

codspeed Bot commented Oct 27, 2026

Merging this PR will improve performance by 11.25%

Performance Changes

Footnotes

Uh oh!

ryansolid commented Oct 27, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants