fix: drop displayName from getLanguageModelKey to fix MCP model selection#1408
fix: drop displayName from getLanguageModelKey to fix MCP model selection#1408salarkhannn wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis change updates ChangesLanguage model key fix
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Line 30: The CHANGELOG entry is linking to the originating issue instead of
the pull request. Update the markdown link in the release note entry to use the
PR id in the same `[#<id>](<url>)` format as the other entries, and keep the
text associated with the `getLanguageModelKey` change unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 761e4946-6550-4460-8115-bb079acb29e7
📒 Files selected for processing (2)
CHANGELOG.mdpackages/web/src/features/chat/utils.ts
Fixes #1137
getLanguageModelKeyincludeddisplayNamein the model key, butdisplayNameis a cosmetic label, not an identity field. The MCP schema only exposes{provider, model}, so explicit model selection via theask_codebasetool always produced a key mismatch.Dropping
displayNamefrom the key fixes the MCP path at the root and prevents the same bug pattern from appearing in other callers.Summary by CodeRabbit