feat: add force16Color config option#1337
Open
jojosenthusiast wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1144
Reproduction
srcpreviously either emitted no colours or 256-colour ANSI SGR sequences such as38;5;N/48;5;N. Users with terminal themes that make those 256-colour choices hard to read had to disable colour entirely.Fix summary
force16Colorto~/src-config.jsonparsing.cmd/srcandlib/output256-colour SGR sequences to terminal-theme 16-colour SGR when enabled.ansiColorsentries.Tests run
go test -count=1 ./cmd/src(cd lib && go test -count=1 ./output)gofmt -l cmd/src/cmd_test.go cmd/src/colors_test.go cmd/src/run_migration_compat_test.go cmd/src/main_test.go cmd/src/colors.go cmd/src/cmd.go cmd/src/main.go cmd/src/run_migration_compat.go lib/output/style.go lib/output/style_test.go lib/output/setup_test.goLean already. Ship.Risk
Low-to-medium. This touches global CLI colour rendering state, but the default behavior is unchanged unless
force16Coloris enabled. Regression tests cover config parsing, legacy command dispatch, migrated command dispatch,cmd/srccolour remapping,lib/outputstyle remapping, and disabled-colour preservation.Non-goals