Fix date round-trip bugs across non-UTC timezones - #107
Merged
Merged
Conversation
- Force UTC in package dates and document created date parsing - Add timezone and daylight saving regression test Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
bact
marked this pull request as ready for review
September 17, 2026 16:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #106.
PR #100 correctly changes date string formatting to UTC (per SPDX spec) but haven't yet change cell value read/write - so they are still use default JVM timezone, and fail round-trip tests on non-UTC timezone (on local machines, as reported on #106)
This PR:
Since there a lot of bolilerplate for date/time and number read from/write to cell, I put them in helper function - also to avoid drifts in the future.
Implementation details
AbstractSheethelpers (SPDX_UTC_DATE_FORMAT,getCellLocalDateTimeUtc,formatCellUtcDate,parseUtcDate,toUtcLocalDateTime) replace per-fileDATE_FORMATaliases and duplicated conversionsAnnotationsSheet,DocumentInfoSheet,DocumentInfoSheetV2d0,PackageInfoSheetV2d3all use themOdsCell.getLocalDateTimeCellValueto throws on wrong-typed cells like real POI;getDateCellValuedelegates to itNote that the adversarial test cases against extreme timezones and daylight saving edge cases are generated by AI.