Conversation
- `OdsSheet` and `OdsRow` now report row and cell bounds like POI, ignoring empty rows before and after the data (fixes phantom snippets with no ID) - Add LibreOffice-generated ODS fixtures and a generator script - Add parity tests against XLS/XLSX Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
- removeRow: getRow/getLastRowNum ignore the removed row - clear/removeCell clear value, formula, comment, style - createRow replaces an existing row - Need spdx#110 to merge first Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
bact
marked this pull request as draft
September 19, 2026 10:19
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Based on changes in PR #110. Don't review until PR #110 get merged.
PR #110 made ODS row and cell bounds count style, formula and comment, not just value.
clear,removeCellandcreateRowonly cleared values, so removed rows and cells could still be found.What this PR changes:
clearandremoveCellclear value, formula, comment and styleremoveRowrecomputes the cached row bounds, sogetRowandgetLastRowNumignore a removed first or last rowcreateRowon an existing row replaces it: no cells, default height, visibleremoveRowresets height and visibility the same waygetRowstill returns an empty row between data rows (POI returns null). ODS can't tell a missing row from an empty one.