chore(deps): bump ruff ^0.12.3 → ^0.15.22 and openapi-python-client ^0.26.1 → ^0.29.0 (HYBIM-777)#94
chore(deps): bump ruff ^0.12.3 → ^0.15.22 and openapi-python-client ^0.26.1 → ^0.29.0 (HYBIM-777)#94etserend wants to merge 4 commits into
Conversation
…0.26.1 → ^0.29.0 (HYBIM-777) openapi-python-client 0.26.x hard-caps ruff<0.14, so both versions must be bumped together. Also updates the ruff pre-commit hook rev to v0.15.22. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…-python-client 0.29.x output (HYBIM-777) The 0.26.x → 0.29.x upgrade changed the generated http_validation_error.py from_dict body structure: field init and loop ordering changed, and the guard changed from `_detail or []` to `if _detail is not UNSET`. Update _LOOP_RE and _loop_replacement to match the new pattern so the post-gen hook succeeds. Also apply ruff UP-rule auto-fixes (StrEnum, dt.UTC, import ordering) that the bumped ruff 0.15.22 now flags. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
49ec893 to
2775d7b
Compare
…M-777) - Remove unused `timezone` import from utils/__init__.py (F401) - Add explicit `__hash__ = None` to schema/message.py (PLW1641) - Add experiment.py and metric.py to per-file-ignores for PLC0415 (local imports are intentional circular-dependency workarounds) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Ran
The branch introduces no new errors — it fixes all 11 pre-existing ones on |
fercor-cisco
left a comment
There was a problem hiding this comment.
🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.
Verdict: approve — Clean, well-scoped dependency bump; code changes correctly satisfy new ruff rules with no runtime regressions found. One non-blocking verification gap on the patch script.
Follow-ups
Suggested follow-up work that could be tracked as Shortcut stories:
scripts/patch_http_validation_error.py:54-101: Add a small unit test for the patch script that feeds a representative 0.29-generatedfrom_dictbody throughpatch()and asserts the isinstance-guarded output is produced. This turns the currently-untested regex into a regression-guarded contract and would have caught any generator drift at CI time rather than at regen time.
Verify the 0.29 regex against a representative unpatched from_dict body, confirm idempotency on already-patched content, and assert the committed http_validation_error.py already carries the patch sentinel. Addresses reviewer comment on PR #94. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Added |
Summary
Bumps ruff and openapi-python-client together — they are coupled because
openapi-python-client 0.26.xhard-capsruff<0.14, making it impossible to resolve ruff ≥0.14 while staying on 0.26.x.ruff(pyproject.toml)^0.12.3^0.15.22ruff(pre-commit hook)v0.9.7v0.15.22openapi-python-client^0.26.1^0.29.0These were previously bumped in PR #66, reverted in PR #78 (due to an unrelated openapi.yaml conflict), and are now re-applied cleanly.
Test plan
poetry run ruff check src/splunk_ao/ --exclude src/splunk_ao/resources/— no new errorsTicket: HYBIM-777
🤖 Generated with Claude Code