Repository navigation
Allow JDK immutable collections in CoreJacksonModule - #20108
Open
rajeshvasa wants to merge 1 commit into
Open
rajeshvasa wants to merge 1 commit into
rajeshvasa wants to merge 1 commit into
Conversation
Closes spring-projectsgh-20084 Signed-off-by: Rajesh Vasa <guptha.rh@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
rajeshvasa
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoreJacksonModule's allowlist includes the olderjava.util.Collections$Unmodifiable*,SingletonListandArrays$ArrayListtypes but not the JDK 9+java.util.ImmutableCollectionsimplementations produced byList.of,Set.of,Map.ofandStream.toList(). Claims built that way are saved byJdbcOAuth2AuthorizationServicebut fail withInvalidTypeIdExceptionwhen read back (e.g. on refresh).This adds
List12,ListN,Set12,SetN,Map1andMapNto the allowlist.Tests:
ImmutableCollectionsTests: round-trip for each type (all 8 fail without the change)JdbcOAuth2AuthorizationServiceTests: save/load of access token claims containing immutable collections, reproducing the reportCloses #20084