Repository navigation
Use requested scope when refresh response omits it - #20110
Open
amalsaidov wants to merge 1 commit into
Open
amalsaidov wants to merge 1 commit into
amalsaidov wants to merge 1 commit into
Conversation
When a refresh token response omits the scope parameter, RFC 6749 section 5.1 defines the granted scope as identical to the scope requested by the client. Both refresh token response clients fell back to the previously granted scope instead, so a request that narrowed the scope kept the wider scope in the resulting access token. Fall back to the requested scope when it is present, and otherwise to the previously granted scope. Closes spring-projectsgh-20063 Signed-off-by: amalsaidov <amalsaidov@users.noreply.github.com>
spring-projects-issues
added
the
status: waiting-for-triage
|
Have you had a chance to read the last part of the issue? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a refresh token response omits the
scopeparameter, RFC 6749 section 5.1 defines the granted scope as identical to the scope requested by the client.RestClientRefreshTokenTokenResponseClientandWebClientReactiveRefreshTokenTokenResponseClientboth fell back to the previously granted scope instead, so a request that narrowed the scope (for example fromread writedown toread) kept the wider scope in the resulting access token.This changes only the scope metadata recorded by the client. It does not change what the authorization server grants, and the resulting scope is narrower rather than wider.
The clients now fall back to the requested scope when it is present, and otherwise to the previously granted scope (RFC 6749 section 6, where an omitted request scope equals the originally granted scope).
Added a regression test to each client covering a narrowed request with a response that omits
scope.AI-assisted; directed, reviewed and tested by the author.
Closes gh-20063