Repository navigation
Conversation
findByToken(token, null) also matches the state attribute, so a value equal to a stored state (for example the PAR request_uri reference) found an authorization without a matching token. The providers then failed an assertion and the request ended with an IllegalArgumentException. Treat that case as an unknown token: introspection returns an inactive response (RFC 7662 section 2.2) and revocation returns success without revoking anything (RFC 7009 section 2.2). Signed-off-by: shlee1223 <shlee1223@raoncorp.com>
spring-projects-issues
added
the
status: waiting-for-triage
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
findByToken(token, null)also matches thestateattribute, so a value equal to a stored state (e.g. from a PARrequest_uri) finds an authorization with no matching token, and the introspection and revocation providers fail with anIllegalArgumentException.This treats that case as "token not found", which returns
"active": false(RFC 7662 §2.2) and 200 for revocation (RFC 7009 §2.2). Tests added.