Skip to content

ClickHouse: support the strictness before the join type (ASOF LEFT JOIN, ANY LEFT JOIN, ...) #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MunMunMiao wants to merge 1 commit into from
Closed

ClickHouse: support the strictness before the join type (ASOF LEFT JOIN, ANY LEFT JOIN, ...) #987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/languages/clickhouse/clickhouse.formatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,10 @@ const reservedSetOperations = expandPhrases([
const reservedJoins = expandPhrases([
// https://clickhouse.com/docs/sql-reference/statements/select/join
'[GLOBAL] [INNER|LEFT|RIGHT|FULL|CROSS] [OUTER|SEMI|ANTI|ANY|ALL|ASOF] JOIN',
// The strictness can also come before the join type, e.g. `ANY LEFT JOIN`, `ALL INNER JOIN`
// and `ASOF LEFT JOIN`, which the documentation uses as well:
// https://clickhouse.com/docs/sql-reference/statements/select/join#asof-join-usage
'[GLOBAL] {ANY|ALL|ASOF} [INNER|LEFT|RIGHT|FULL] [OUTER] JOIN',
// https://clickhouse.com/docs/sql-reference/statements/select/array-join
'[LEFT] ARRAY JOIN',
]);
Expand Down
18 changes: 18 additions & 0 deletions test/clickhouse.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,24 @@ describe('ClickhouseFormatter', () => {
'GLOBAL ALL JOIN',
'GLOBAL ASOF JOIN',

// Strictness before the join type
'ANY INNER JOIN',
'ANY LEFT JOIN',
'ANY RIGHT JOIN',
'ANY FULL JOIN',
'ALL INNER JOIN',
'ALL LEFT JOIN',
'ALL RIGHT JOIN',
'ALL FULL JOIN',
'ASOF INNER JOIN',
'ASOF LEFT JOIN',
'ASOF RIGHT JOIN',
'ASOF FULL JOIN',
'ANY LEFT OUTER JOIN',
'ASOF LEFT OUTER JOIN',
'GLOBAL ANY LEFT JOIN',
'GLOBAL ASOF LEFT JOIN',

'GLOBAL JOIN',

'OUTER JOIN',
Expand Down