Don't add a space before a parenthesis or bracket that continues an expression (quantile(0.9)(x), splitByChar(',', s)[1], col[1])

[MunMunMiao]

Problem

A parenthesis or bracket that directly continues the previous expression gets a space in front of it when that expression is a function call, a parenthesis, a quoted identifier, a property access or a subscript. Only an unquoted identifier is handled (c[1], through the ARRAY_IDENTIFIER token).

SELECT quantile(0.9)(x), splitByChar(',', s)[1], (arr)[1], `signals`[1], t.`signals`[2], c[1][2] FROM t

Before (15.9.0, language: 'clickhouse'):

SELECT
  quantile(0.9) (x),
  splitByChar(',', s) [1],
  (arr) [1],
  `signals` [1],
  t.`signals` [2],
  c[1] [2]
FROM
  t

After:

SELECT
  quantile(0.9)(x),
  splitByChar(',', s)[1],
  (arr)[1],
  `signals`[1],
  t.`signals`[2],
  c[1][2]
FROM
  t

It is not limited to ClickHouse: BigQuery gives SPLIT(s, ',') [OFFSET(1)] and `col` [0], and PostgreSQL gives "col" [1] and string_to_array(s, ',') [1].

Change

ExpressionFormatter.formatParenthesis now removes the space in front of the node when it directly follows another node of the same list and

• it opens with ( and the previous node is a function call (quantile(0.9)(x)), or
• it opens with [ and the previous node is a function call, a parenthesis, a quoted identifier, a property access or a subscript.

A parenthesis or bracket after a keyword is not affected, so x IN [1, 2], IN (1, 2) and OVER (...) look as before. The parenthesis that belongs to a function call is handled as before, because it is not a node of the list.

I tried a grammar change first, but the parser rejects ambiguous grammars and f(a) (b) is already valid as two expressions. Looking at the previous node in the formatter avoids that.

Tests

• ClickHouse: parametric aggregate functions, subscripts after calls, parentheses, quoted identifiers, property access and subscripts, and that x IN [1, 2] keeps its space.
• BigQuery and PostgreSQL: a subscript after a function call, a quoted identifier and a parenthesis.

pnpm exec jest passes for all dialects (5890 passed, 1 skipped). No existing expectation changed. tsc --noEmit, prettier --check and eslint are clean.

Fixes #991.

---

This change was prepared with Claude Code (an AI coding assistant) and checked by running the full test suite locally.

[Copilot]

🟡 Changes recommended

The formatter cannot distinguish adjacent syntax from whitespace-separated expressions and may alter query semantics.

1 open finding

• Rewrites whitespace-separated expressions as chained calls · New

What changed in this PR

Updates expression formatting so chained calls and subscripts render without an intervening space.

Changes:

• Detects parentheses and brackets that follow compatible expression nodes.
• Adds ClickHouse, BigQuery, and PostgreSQL regression tests.

File	Description
src/​formatter/​ExpressionFormatter.ts	Adds continuation-spacing logic.
test/​clickhouse.test.ts	Tests chained calls and subscripts.
test/​bigquery.test.ts	Tests function and identifier subscripts.
test/​postgresql.test.ts	Tests several subscript forms.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[MunMunMiao]

Closing for now: I'm going to handle the formatting on my side instead. Thanks for the library.