docs: document SQLite batch migrations with views - #1862
Open
Ryota-Di wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks! Issue #1207 is now marked code review in progress and no longer open for pull requests, so this pull request holds the review for it and another one won't land on top of your work. If this pull request is abandoned, a maintainer can put open for pull requests back on #1207 to reopen it to others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project accepts pull requests only for issues that a maintainer has
marked with the
open for pull requestslabel.A pull request that doesn't reference such an issue is closed
automatically. That isn't a judgment on your change: it's how we settle on
an approach before anyone spends time writing code, and how we keep two
people from doing the same work at once.
The issue you reference has to be:
open for pull requests, andcode review in progress, which means someone isworking on it already.
If there's no such issue yet, open one describing the problem or the feature,
including a complete, runnable example, and wait for a maintainer to add the
label. Please don't open a pull request first and ask for the label
afterwards.
Fixes
Fixes: #1207
Description
Documents a SQLite limitation when using batch migrations with views that
reference the table being recreated.
During the "move and copy" workflow, the original table is temporarily
dropped before the replacement table is renamed. SQLite may reject the
rename when an existing view still refers to the temporarily missing table.
The documentation also notes that temporarily enabling
PRAGMA legacy_alter_tablewhile the replacement table is renamed can beused as a workaround.
Verification:
git diff --checkPRAGMA legacy_alter_tableallows thebatch migration to complete and leaves the referencing view usable