Skip to content

SAAS-10250 - build-plugin: the platform now provides Ignore certificate errors - #143

Merged
clarkd merged 1 commit into
mainfrom
work/dc/platform-ignore-certificate-errors
Oct 15, 2026
Merged

clarkd merged 1 commit into
mainfrom
work/dc/platform-ignore-certificate-errors

Conversation

@clarkd

@clarkd clarkd commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

📋 Summary

This PR updates the build-plugin skill so it stops telling authors to add their own ignoreCertificateErrors checkbox to ui.json. SquaredUp now adds an "Ignore certificate errors" toggle to every plugin built on WebAPI (SAAS-10250), so new plugins don't need the field, or a base.config mapping for it.

The skill also explains that declaring the field, or setting the key in base.config, stops the platform adding its toggle. That's only worth doing for an API where the option makes no sense, and it only hides the option on the form.

Important

Please don't merge until the SAAS-10250 platform change is in prod. Before then, a plugin built with this guidance would ship with no option at all.

Existing plugins that already declare the field don't need to change. The platform skips them.

🔍 Scope of change

  • Documentation only
  • Repository metadata or configuration
  • CI / automation
  • Other (please describe):

📚 Checklist

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Clarified that WebAPI-based plugins receive a platform-provided certificate-error toggle by default.
    • Documented when to declare this option explicitly and how user-provided values can override the configuration.

SquaredUp now adds the toggle to every WebAPI-based plugin, so new
plugins shouldn't declare their own field. Document the base.config
literal as the opt-out.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@clarkd clarkd added the documentation Improvements or additions to documentation label Oct 13, 2026
@github-actions

Copy link
Copy Markdown

🧩 Plugin PR Summary

ℹ️ No plugins were modified in this PR.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Enterprise
  • Run ID: b40045a2-30f9-4c71-8ee6-68ff7db9558c
📥 Commits

Reviewing files that changed from the base of the PR and between 46726e1 and c0a755d.

📒 Files selected for processing: 1
  • .claude/skills/build-plugin/references/ui.md

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The plugin UI guidance now describes the platform-provided ignoreCertificateErrors toggle for WebAPI-based plugins, when declaring the option hides the toggle, and how user-supplied values can override base.config.

Changes: Plugin UI guidance

Layer / File(s) Summary
Document certificate error configuration
.claude/skills/build-plugin/references/ui.md
The guidance says WebAPI-based plugins receive a platform toggle. Declaring the field or a base.config key hides the toggle, but does not prevent user-supplied values from overriding the configuration. The example places ignoreCertificateErrors: false in the WebAPI base configuration.

Priority: ⬇️ Low

Merge Risk: 🔵 Low · up to c0a75

This updates plugin-authoring guidance to rely on a platform-provided certificate-error toggle. The author says not to merge until the platform change is live; if it is not, new plugins following this guidance would have no such option. Confirm the rollout before merging.

### Architecture Summary

Architecture risk: 🔵 Low · up to c0a75

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .claude/skills/build-plugin/references/ui.md: Replaces the recommendation to add a checkbox for plugins connecting to on-prem instances with self-signed certificates. The guidance now says WebAPI-based plugins receive a platform-provided toggle, and that a declared field or base.config key hides that toggle without preventing user-supplied values from overriding the configuration. The example now shows ignoreCertificateErrors: false in the WebAPI base configuration.
Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly identifies the build-plugin documentation change and the platform-provided Ignore certificate errors toggle.
Description check Passed The description is complete and relevant. It explains the behavior change, scope, platform dependency, impact on existing plugins, and documentation-only scope.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@clarkd
clarkd marked this pull request as ready for review October 13, 2026 22:06
@clarkd
clarkd requested a review from a team October 13, 2026 22:06
Comment thread .claude/skills/build-plugin/references/ui.md
@clarkd
clarkd merged commit 0d75f6e into main Oct 15, 2026
1 check passed
@clarkd
clarkd deleted the work/dc/platform-ignore-certificate-errors branch October 15, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Development

Successfully merging this pull request may close these issues.

2 participants