Repository navigation
Fix OpenSearch and UptimeRobot failing validation on deploy - #144
Merged
Merged
Conversation
The index autocomplete on the Search data stream loads its options from a data stream but had no dataSourceConfig, which the UI schema requires for that source. Add an empty one, as every other plugin does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The monitors import step set dataSourceConfig on its data stream, which the strict import step schema rejects (the file format key is config). The value was empty, so remove it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pagingConfig_mode and pagingConfig_offset_base are an old flattened form the WebAPI handler never reads (it reads config.paging, and treats a missing one as no paging, which is what mode none meant). The WebAPI data stream schema used by squaredup validate rejects them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🧩 Plugin PR Summary📦 Modified Plugins
📋 Results
|
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 5
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
This PR fixes OpenSearch and UptimeRobot failing to redeploy to dev with a 500 from the Management API. Both plugins last deployed in March. Since then, deploy-time validation has got stricter, and each one has a field it now rejects.
monitorsimport step setdataSourceConfig: {}on its data stream. The strict import step schema rejects that key (the file format key isconfig). The value was empty, so I've removed it.dataSourceConfig, which the UI schema requires for that source. I've added an empty one, as every other plugin does. I've also removed the oldpagingConfig_mode/pagingConfig_offset_basekeys from both data streams. The WebAPI handler never reads them, andsquaredup validaterejects them.Both plugins get a patch version bump. This PR touches two plugins, so the one-plugin-per-PR check will fail. I'm skipping the PR automation for this one and validated locally instead.
🔗 Related issue(s)
🧩 Plugin details
🧪 Testing
squaredup validatepasses locally for both plugins. Before these changes, it reported the same errors that dev's deploy hit, plus the paging keys. I also ran the deploy path's own archive validators (getDataStreamsFromArchive/getImportDefinitionsFromArchive) against both plugins, and both pass now.I haven't tested against live OpenSearch or UptimeRobot instances. The changes only touch config the handler either doesn't read or treats the same way when it's empty.
Does this PR introduce any breaking changes?
📚 Documentation
✅ Checklist
🤖 Generated with Claude Code