Fix bad uses of OpenSSL 0.9 API - #2441
Open
yadij wants to merge 2 commits into
Open
Conversation
These ASN1_STRING_* API functions have been available since OpenSSL 1.1, and Squid provides portability wrappers for OpenSSL v1.0. OpenSSL v4 removes struct asn1_string_st from public availability. Leading to compile problem: error: invalid use of incomplete type ASN1_OCTET_STRING
yadij
added
S-could-use-an-approval
rousskov
requested changes
Jun 9, 2026
| // GEN_DNS is an IA5STRING. IA5STRING is a subset of ASCII that does not | ||
| // need to be converted to UTF-8 (or some such) before we parse it. | ||
| const auto buffer = Ssl::AsnToSBuf(*san.d.dNSName); | ||
| const SBuf buffer(reinterpret_cast<const char *>(ASN1_STRING_get0_data(san.d.dNSName)), ASN1_STRING_length(san.d.dNSName)); |
Contributor
There was a problem hiding this comment.
Why replace our reusable conversion function with this direct conversation code?
Contributor
Author
There was a problem hiding this comment.
It is used only once, increases dependency footprint, wrong scope, and badly named. Overall "bad design" and you would say.
Contributor
There was a problem hiding this comment.
I disagree with your assessment. Please undo this out of scope removal.
Contributor
Author
There was a problem hiding this comment.
That would be your personal coding style preferences.
Best practice coding is not to create gratuitous wrapper APIs for a single line of code - especially when the wrapper merely existing adds code dependencies.
rousskov
added
S-waiting-for-author
yadij
removed
the
S-waiting-for-author
rousskov
added
S-waiting-for-author
rousskov
removed their request for review
June 10, 2026 08:44
squid-anubis
added
M-failed-other
yadij
added
the
S-waiting-for-reviewer
yadij
removed
the
S-waiting-for-author
Contributor
|
Building squid-7.7 with this PR applied, gcc-16.x and OpenSSL 4.0.2 is still broken: |
Contributor
Author
|
@bkuhls aye, this is the first of a series of PRs needed to make OpenSSL v4 builds work. This one scoped at fixing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct access to struct asn1_string_st internals has been
deprecated since OpenSSL v1.0.
OpenSSL v4 removes struct asn1_string_st from public
availability. Leading to compile problem:
error: invalid use of incomplete type ASN1_OCTET_STRING
Squid should be using the API for OpenSSL v1.1 and later.