fix(rust,scala): fix args truncation by ignoring lifetime/symbol marks - #2133
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1872
Summary
This PR correctly identifies Rust lifetimes and Scala symbols during function parameter string tokenization by using
self.primary_lang_idinstead ofgetattr(self, 'language', '')(which was dead code because the class doesn't define it). It also adds the identical check to_matching_paren_endto prevent it from getting hopelessly stuck looking for a matching string delimiter that never comes.Both golden masters have been regenerated and the missing arguments for these functions have been successfully rescued.