Skip to content

fix(fortran): parse args through cpp macros (#2077) - #2143

Merged
squid-protocol merged 5 commits into
mainfrom
fix-2077-fortran-args
Aug 22, 2026
Merged

fix(fortran): parse args through cpp macros (#2077)#2143
squid-protocol merged 5 commits into
mainfrom
fix-2077-fortran-args

Conversation

@squid-protocol

Copy link
Copy Markdown
Owner

Fixes #2077. Overrides Fortran args count to track parentheses appropriately when macro conditionals appear in the parameter list. Also updates all relevant golden masters, baselines, and the tri-comparison chart.

squid-protocol and others added 3 commits August 22, 2026 16:21
Adds tests/tools/tri_comparison_chart.py's --ci/--regenerate mode, gated on
GitGalaxy's own ledger-validated precision (never a raw disagreement count) --
recall is deliberately excluded, since the chart's own docstring already
explains why that ratio's cross-tool denominator isn't trustworthy to rank on.

Two new workflows mirror the existing tree-sitter-accuracy split:
tri-comparison-audit.yml (PR-time, blocking, measures only) and
tri-comparison-history.yml (push-to-main, regenerates chart/ledger/report,
opens an auto-merged PR only when something actually changed). Both hard-fail
if ctags isn't really Universal Ctags, per the PR #2111 incident.

Updates ci-push-checklist and tree-sitter-accuracy-sweep skills, the
tri-comparison README, and CLAUDE.md's Differential Scan section to reflect
the new gate.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ros (#2077)

Fortran argument parsing was terminating early at the first `)', which could be part of an embedded preprocessor conditional. By overriding the args count with `_count_top_level_args`, we now track parenthesis depth correctly.

Fixes #2077
@github-actions

Copy link
Copy Markdown
Contributor

🐦‍⬛ Muninn Security Scan

✅ No security issues found.

🐦‍⬛ Powered by Muninn · Skald Lab

@squid-protocol
squid-protocol merged commit f9fd258 into main Aug 22, 2026
30 checks passed
@squid-protocol
squid-protocol deleted the fix-2077-fortran-args branch August 22, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fortran args regex undercounts when a CPP-guarded parameter's #if expression contains ')' before the real signature closes

1 participant