feat(drivers): one place to see and choose a driver version - #1427
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 699213b496
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if repositoryID == "" { | ||
| if err := m.refreshOne(ctx, m.betaRepo); err != nil { | ||
| errs = append(errs, fmt.Errorf("%s: %w", m.betaRepo.ID, err)) | ||
| } |
There was a problem hiding this comment.
When the stable manifest refresh succeeds but the independent beta request fails, this error is joined into the overall Refresh result, so the API returns 502 and the Versions panel's promise chain never reloads its list. A beta-channel outage therefore hides newly fetched stable versions even though their verified cache was updated; return per-channel results or let the UI redraw from the successful cache while reporting the beta failure.
Useful? React with 👍 / 👎.
| Promise.all([ | ||
| fetchCatalog("/api/device_repository/catalog"), | ||
| fetchCatalog("/api/device_repository/catalog?channel=beta") |
There was a problem hiding this comment.
When the stable cache is stale, clicking “Look for more drivers” does not actually check the stable channel: /api/device_repository/catalog calls the cache-only Manager.Catalog, while only the beta endpoint performs a network refresh. A newly published stable-only driver can therefore remain absent until the 24-hour background refresh despite the UI saying it is checking both signed channels; refresh stable before fetching these catalogs.
AGENTS.md reference: AGENTS.md:L22-L23
Useful? React with 👍 / 👎.
|
Codex review: two findings. (1) Fixed in the latest commit: after a switch, "Check for new versions" redrew the picker from stale running-state options and hid the way back to the release's copy; covered by a new test that fails on the previous code. (2) For bundled drivers whose id is spelled differently from the channel, the Versions list finds no signed versions — resolved at the source by srcfl/device-drivers#132 and the FTW pin that follows it, so this PR should merge together with or after that pin. |
Independent review of #1427: - AvailableVersions matched an install to a candidate by repository, version and hash. A beta file that stable then published byte for byte lost its "running" and "chosen" marks, and "Use this" would fetch it again. Installs now match by version and hash. - Refresh with no id also fetched the beta channel and failed the whole request when beta was unreachable, so "Check for new versions" did not redraw, and every box's daily refresh reached the beta channel. Refresh again reads only the configured sources; RefreshAll, used by the owner's check, adds beta and reports its failure as a warning, which the panel shows under a redrawn list. - "Look for more drivers" used Promise.all, so an unreachable beta hid the stable channel's drivers. It uses allSettled and says which channel could not be reached. - A channel version equal to the release's reads "same as this release", not "until a release has it". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MuerPFZFG88kgu8sWVHeq7
The owner's rule: an owner picks which signed driver version runs, it is seen and changed in one place, and nothing lights up on its own. - Each device's Versions list under Settings > Devices is that place. It lists the release's own copy first (with its version), the signed stable versions and any beta newer than stable, marked. The owner's choice is marked "chosen, kept across updates". Every version links to what changed: the driver's history in device-drivers at the commit it was published from. "Check for new versions" refreshes both signed channels and redraws the list; nothing installs. - The device line says where the running driver comes from: this release, chosen and kept across updates, until a release has it, or your own file. The "Update to vX" button is gone. - Update Center lists no drivers and the header counts only Core. System no longer refreshes driver catalogs. - Adding a device: "Look for more drivers" fetches the driver types the release does not carry, from the driver channel or, marked, from beta, into the same list. The add path installs them from their channel. The old list never offered stable channel-only drivers; they were reachable only through the beta selector. - API: /versions returns release_version, chosen_version, logical_path and the release's pinned source; candidates carry channel and repository. The catalog marks a chosen override. One refresh reads both channels. `ftw status` tells a chosen override from an early one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MuerPFZFG88kgu8sWVHeq7
Codex review: after a switch, "Check for new versions" rebuilt the picker from the options captured when it was opened. With the release's copy running at first, the redraw still marked it as running and hid its "Use this" button, so the way back disappeared. refreshSummary now updates the running source and version in those options, as it already did for the button's dataset. The new test fails on the previous code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MuerPFZFG88kgu8sWVHeq7
Independent review of #1427: - AvailableVersions matched an install to a candidate by repository, version and hash. A beta file that stable then published byte for byte lost its "running" and "chosen" marks, and "Use this" would fetch it again. Installs now match by version and hash. - Refresh with no id also fetched the beta channel and failed the whole request when beta was unreachable, so "Check for new versions" did not redraw, and every box's daily refresh reached the beta channel. Refresh again reads only the configured sources; RefreshAll, used by the owner's check, adds beta and reports its failure as a warning, which the panel shows under a redrawn list. - "Look for more drivers" used Promise.all, so an unreachable beta hid the stable channel's drivers. It uses allSettled and says which channel could not be reached. - A channel version equal to the release's reads "same as this release", not "until a release has it". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MuerPFZFG88kgu8sWVHeq7
585f2dd to
29fc1f2
Compare
1 participant
The owner's rule for driver versions: an owner picks which signed version runs; it is seen and changed in one place; nothing lights up on its own. Items 3 and 4 of #1423, plus the owner's request for a clear changelog per version.
What changes
One place: each device's Versions list under Settings → Devices.
BUNDLED_SOURCE.json. Only a GitHub source with a hex commit gets a link.The device line says where the running driver comes from:
this release;chosen, kept across updates · release has v2.1.2;until a release has it · release has v…;your own file.The "Update to vX" button is gone.
Other surfaces:
API and CLI:
/versionsreturnsrelease_version,chosen_version,logical_pathandrelease_source(the pinned repository and commit).channelandrepository.chosenoverride.POST /refreshwith no id reads the beta channel too.ftw statustells a chosen override apart from an early one.Known limit
For the ~21 bundled drivers whose source
DRIVER.idis spelled differently from the channel (sungrow-shxvssungrow,easee-cloudvseasee_cloud), the Versions list finds no channel versions yet. It shows only the release row. Item 1 of #1423 fixes this at the source in device-drivers: one id and one version per driver.Evidence
go test:driverrepo,api,ftwcli,driversandcmd/ftwpass. New tests:/versionsreturning the release version and the owner's choice;npm test: 633 pass (run withLC_ALL=C.UTF-8; see fix(drivers): keep the owner's driver choice and meet both id spellings #1426 for the locale-dependent backup test).driver-versions.test.mjsdrives the real code with a DOM shim. It now covers the release row first and running, rows found by what they are, beta install through the channel, the chosen mark, the "What changed" links (including a refusedjavascript:source) and the refresh-and-redraw.A human needs to look at this in a browser before merge (AGENTS.md). Screenshots were sent to the owner.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MuerPFZFG88kgu8sWVHeq7