Repository navigation
Conversation
hugodeco
requested review from
Rob-Hague,
WojciechNagorski and
drieseng
as code owners
November 11, 2026 20:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consuming the SSH.NET 2026 netstandard2.0 asset from net7.0 fails a warnings-as-errors build because System.Formats.Asn1 10 requires a newer supported runtime. The same asset also exposes IAsyncEnumerable through ListDirectoryAsync without declaring Microsoft.Bcl.AsyncInterfaces directly: modern consumers select the modern logging asset, lose the indirect interface dependency, and fail with CS0012.
This change uses ASN.1 8.0.2 for netstandard2.0 and declares AsyncInterfaces 8.0.0 directly for that asset. Other assets retain their existing dependency choices. No SSH.NET downgrade or SCP security fix is reverted, and no TFM warning is suppressed. An opt-in build property lets the existing unit suite exercise the netstandard2.0 library from a current test host; Linux CI runs that path. The socket test helper explicitly selects the host Lock to avoid an ambiguous reference to the compatibility implementation.
Validation:
-warnaserror, then ran under native .NET 7.0.20: six encrypted/unencrypted PKCS8 key fixtures (RSA, ECDSA, Ed25519), signing/verification, altered-message rejection, and disconnected async SFTP enumeration passed.Compatibility and validation record. This is compatibility of an existing netstandard2.0 asset, not a claim of renewed official support for the end-of-life .NET 7 runtime.
AI disclosure: implementation, investigation, tests and this description were prepared by OpenAI Codex at the maintainer's request. This submission is made through hugodeco's GitHub account at his explicit request. No human line-by-line review is asserted.