Repository navigation
Inline ProtocolVersionExchange into Session - #1867
Merged
Merged
Conversation
Two motivating reasons: 1. Rather than reading one byte at a time from the socket, we can use the receive buffer to read as much as is available. Once we've read out the SSH identification, leftover bytes are processed as the kexinit messages as normal. 2. To replace explicit tests and mocks on internals (ProtocolVersionExchange class) with tests on public API. This is a first attempt in that direction. The logic is also rewritten to use spans on bytes rather than materialising strings and using regex.
Rob-Hague
requested review from
WojciechNagorski and
drieseng
as code owners
November 14, 2026 12:50
WojciechNagorski
approved these changes
Nov 14, 2026
# Conflicts: # src/Renci.SshNet/Connection/ProtocolVersionExchange.cs
Collaborator
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two motivating reasons:
to read as much as is available. Once we've read out the SSH identification, leftover
bytes are processed as the kexinit messages as normal.
tests on public API. This is a first attempt in that direction.
The logic is also rewritten to use spans on bytes rather than materialising strings and
using regex.