feat(publish-image-index-manifest)!: Support other/additional tags - #140
Open
Techassi wants to merge 5 commits into
Open
feat(publish-image-index-manifest)!: Support other/additional tags#140Techassi wants to merge 5 commits into
Techassi wants to merge 5 commits into
Conversation
Techassi
marked this pull request as ready for review
August 21, 2026 10:02
Techassi
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
dervoeti
requested changes
Aug 27, 2026
|
|
||
| ### Outputs | ||
|
|
||
| - `image-index-uri`: The final image index URI, eg. `oci.stackable.tech/spd/kafka:3.4.1-stackable0.0.0-dev`. |
Member
There was a problem hiding this comment.
Suggested change
| - `canonical-image-index-manifest-uri`: The final image index URI, eg. `oci.stackable.tech/spd/kafka:3.4.1-stackable0.0.0-dev`. |
| # oci.stackable.tech/sdp/kafka:3.4.1-stackable0.0.0-dev | ||
| IMAGE_INDEX_URI="$REGISTRY_URI/$IMAGE_REPOSITORY:$IMAGE_INDEX_MANIFEST_TAG" | ||
| echo "IMAGE_INDEX_URI=$IMAGE_INDEX_URI" | tee -a "$GITHUB_OUTPUT" | ||
| IMAGE_REGISTRY_URI="${REGISTRY_URI}/${IMAGE_REPOSITORY}" |
Member
There was a problem hiding this comment.
Suggested change
| IMAGE_REGISTRY_URI="${REGISTRY_URI}/${IMAGE_REPOSITORY}" | |
| IMAGE_REPOSITORY_URI="${REGISTRY_URI}/${IMAGE_REPOSITORY}" |
Maybe rename this? Since it includes the repo
| IMAGE_VERSION: ${{ matrix.versions }} | ||
| shell: bash | ||
| run: | | ||
| FLOATING_IMAGE_INDEX_MANIFEST_TAG=$(boil tools floating-tag "${SDP_VERSION}-pr-321") |
Member
There was a problem hiding this comment.
Suggested change
| FLOATING_IMAGE_INDEX_MANIFEST_TAG=$(boil tools floating-tag "${SDP_VERSION}-pr-321") | |
| set -euo pipefail | |
| FLOATING_IMAGE_INDEX_MANIFEST_TAG=$(boil tools floating-tag "${SDP_VERSION}-pr-321") |
dervoeti
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for other/additional image index manifest tags. The current solution is not optimal, but this is the last missing piece to test the floating tag from end-to-end.