fix(superset): Remove NodeJS from final image - #1623
Merged
Conversation
Techassi
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Superset image ships a full Node and npm installation that is only needed to build the frontend.
The reason is the download location:
nvm.shwas written to/stackable/nvm.sh, and nvm derives its installation directory from the location of that script whenNVM_DIRis unset. Node therefore ends up in/stackable/versions, and the final image copies/stackable/from the builder as a whole.Setting
NVM_DIR=/opt/nvmand downloadingnvm.shthere keeps the whole nvm tree outside the copied directory. This mirrors what the cdxgen Node installation in/opt/node-cdxgenalready does.Besides the smaller image, this also removes a Node runtime that is never executed but is picked up by the vulnerability scans.
Other images were checked and are not affected: Airflow, NiFi, Kafka, Trino and OPA ship no Node at all, and OpenSearch Dashboards needs it at runtime.
Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
boilto retrieve the image manifest URI for<MANIFEST_URI>.