fix: KRaft shutdown#982
Draft
NickLarsenNZ wants to merge 7 commits into
Draft
Conversation
This ensures Kafka brokers don't hang when kraft controlers are shutdown on namespace deletion by kuttl
kuttl seems to track cluster scoped resources and deletes them, leaving other tests running in parallel to fail.
Without this, scaling brokers to 0 blocks reconciliation (so things like controller replicas being set to 0 hangs)
…This is just to check that the code is working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
I worked on this some months ago, and have forgotten where I got to.
The topic has come up again, so I pushed WIP changes to share.
Controllers should be shutdown after brokers. But when brokers are shutdown first, the reconciler gets stuck due to (something about failing to generate the discovery configmap, maybe because there would be no brokers).