Initial commit of a CLI tool to help with NiFi flow migrations - #1
Merged
Conversation
…ngs when running it locally as in GitHub
NickLarsenNZ
reviewed
Oct 9, 2025
NickLarsenNZ
approved these changes
Oct 9, 2025
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
Member
There was a problem hiding this comment.
Approving, although I haven't run it
Techassi
requested changes
Oct 9, 2025
Techassi
left a comment
Techassi
left a comment
Member
There was a problem hiding this comment.
I looked through this PR but didn't run the CLi yet.
Two things:
- Does it make sense to put this code next to the NiFi operator (or in a dedicated "tools" repo)?
- All doc comments should end with full stops. I didn't want to mention this on every doc comment, but I instead only mention it once here.
Techassi
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Co-authored-by: Techassi <git@techassi.dev>
Co-authored-by: Techassi <git@techassi.dev>
Member
Author
|
Doc comments now end in periods with |
Member
Author
|
|
- Remove `new` for Migrator - Rustdoc improvement - Rename lib.rs and move to a migration module
Co-authored-by: Techassi <git@techassi.dev>
Co-authored-by: Techassi <git@techassi.dev>
Member
Author
|
There's probably still a comment or two missing but maybe you can have a look at the resolved ones to clean the PR up a bit first before I tackle them. |
Co-authored-by: Techassi <git@techassi.dev>
Techassi
approved these changes
Oct 13, 2025
lfrancke
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created this for a support case we had.
I modeled the entire structure, lints etc. after the boil tool as that was the last tool we added and I hope that it follows the latest best practices.
Note
Full disclosure: AI was used (Claude) to help me with this but every line was read and checked by me. I haven't done Rust development for real in 2 years or so, be kind.
Important
The build fails due to:
ubuntu-22.04-arm, ubuntu-24.04-arm and windows-11-arm are not supported yet for private repositoriesbut I'll leave it in for now until we decide whether it should be private or public.